Skip to content

Conversation

@wusyong
Copy link
Member

@wusyong wusyong commented Apr 28, 2022

Sorry I forgot to add the version bump in previous PR.
I bump the patch version since this doesn't add or change anything in cssparser itself?
Just realized this changed the minimum rust version.

@wusyong
Copy link
Member Author

wusyong commented Apr 28, 2022

r? @emilio

@wusyong wusyong changed the title Bump version to 0.29.3 Bump version to 0.30.0 Apr 28, 2022
@emilio
Copy link
Member

emilio commented Apr 28, 2022

I'd make a patch version bump. MSRV changes aren't necessarily breaking changes. r=me with that

@emilio
Copy link
Member

emilio commented Apr 28, 2022

@bors-servo delegate+

r=me with that change. You can at-bors-servo r=emilio yourself :)

@bors-servo
Copy link
Contributor

✌️ @wusyong can now approve this pull request

@wusyong
Copy link
Member Author

wusyong commented Apr 29, 2022

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 3873411 has been approved by emilio

@bors-servo
Copy link
Contributor

⌛ Testing commit 3873411 with merge 6865fd0...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
Approved by: emilio
Pushing 6865fd0 to master...

@bors-servo bors-servo merged commit 6865fd0 into servo:master Apr 29, 2022
@wusyong wusyong deleted the bump branch April 29, 2022 08:18
@wusyong wusyong changed the title Bump version to 0.30.0 Bump version to 0.29.3 Apr 29, 2022
@wusyong
Copy link
Member Author

wusyong commented May 2, 2022

@emilio How do we publish latest version to crates.io? Is there a command for bots?

@emilio
Copy link
Member

emilio commented May 2, 2022

Someone with the right permissions needs to do it. I just did :)

@wusyong
Copy link
Member Author

wusyong commented May 2, 2022

I see. Thanks again! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants